[BUGFIX] Le PixSearchInput est sujet à des suppressions de caractères (PIX-11403)
#550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
added
👀 Func Review Needed
👀 Tech Review Needed
cross-team
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr550.review.pix.fr |
yannbertrand
force-pushed
the
fix-pix-search-input
branch
4 times, most recently
from
bf9805a to
cb9d68a
Compare
yaf
reviewed
Feb 26, 2024
| @debounceTimeInMs='0' | ||
| @triggerFiltering={{this.triggerFiltering}} | ||
| @value={{this.dynamicValue}} | ||
| />`); |
There was a problem hiding this comment.
Elle est un peu louche l'indentation ici... C'est voulu ?
There was a problem hiding this comment.
C'est du copier/coller des tests du dessus. Je fais confiance au linter pour me corriger si besoin 😄
yaf
approved these changes
Feb 26, 2024
yannbertrand
force-pushed
the
fix-pix-search-input
branch
from
cb9d68a to
64834d8
Compare
yannbertrand
force-pushed
the
fix-pix-search-input
branch
2 times, most recently
from
b23b359 to
1b5edd0
Compare
xav-car
approved these changes
Mar 5, 2024
xav-car
force-pushed
the
fix-pix-search-input
branch
from
1b5edd0 to
cfc647b
Compare
yannbertrand
added
Func Review OK
🚀 Ready to Merge
and removed
👀 Func Review Needed
labels
pix-service-auto-merge
force-pushed
the
fix-pix-search-input
branch
from
cfc647b to
ea11586
Compare
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Mar 8, 2024
## [44.2.6](v44.2.5...v44.2.6) (2024-03-08) ### 🐛 Correction - [#550](#550) Le `PixSearchInput` est sujet à des suppressions de caractères (PIX-11403)
|
🎉 This PR is included in version 44.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Les recherches avec délai ont parfois un comportement étrange. Après avoir tapé des caractères dans la barre de recherche, il arrive que certains caractères disparaissent. Ça a été constaté sur plusieurs écrans de Pix Admin, en particulier avec des connexions instables.
Chaque champ de recherche a son attribut value configuré en "two-way data binding", c'est à dire que lors d'une modification de l'utilisateur :
debouncevalidé,Voir #8133.
🎁 Proposition
Dissocier la valeur affichée dans le champ de recherche de la valeur.
🌟 Remarques
Aussi
ember-lifelinepour ledebounce. Voir [BUMP] Update dependency eslint-plugin-ember to v12 (admin) pix#8056InputEmber.🎅 Pour tester
CI verte 🟢
(je ne sais pas comment reproduire...)