[DOCS] Remise à jour de la doc de typographies #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr582.review.pix.fr |
|
On a atteint le plafond Chromatic pour le moment 😢 |
yannbertrand
force-pushed
the
update-typography-docs
branch
from
4db2b2d to
2524673
Compare
dlahaye
reviewed
Mar 22, 2024
Comment on lines
+129
to
+131
| ```css | ||
| font-weight: var(--pix-font-normal); | ||
| ``` |
There was a problem hiding this comment.
je ne sais pas ce qu'on peut y faire, mais je trouve le rendu des blocs de code hyper difficile à lire. Le margin-bottom de la div centrale est très très grand.
Le résultat c'est que j'ai du mal à dicerner quel Unstyled est associé à quel bloc de code (cf. capture ci-dessous)
yannbertrand
force-pushed
the
update-typography-docs
branch
from
2524673 to
d9e57b2
Compare
yannbertrand
added
Design review OK
🚀 Ready to Merge
Tech review OK
and removed
👀 Design Review Needed
👀 Tech Review Needed
labels
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Apr 15, 2024
## [45.0.17](v45.0.16...v45.0.17) (2024-04-15) ### ⬆️ Montée de version - [#609](#609) Update dependency @1024pix/stylelint-config to ^5.1.7 (dossier racine) ### ☕ Autre - [#582](#582) Remise à jour de la doc de typographies
|
🎉 This PR is included in version 45.0.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
xav-car
pushed a commit
that referenced
this pull request
Apr 17, 2024
## [45.0.17](v45.0.16...v45.0.17) (2024-04-15) ### ⬆️ Montée de version - [#609](#609) Update dependency @1024pix/stylelint-config to ^5.1.7 (dossier racine) ### ☕ Autre - [#582](#582) Remise à jour de la doc de typographies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Petites remise à jour de la documentation sur les typographies.
Il s'agit notamment d'utiliser dans Storybook les vrais Design Tokens de typo pour mieux visualiser leur impact.