[BUGFIX] corrige la position du chevron dans le multiselect (pix-11962) #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr590.review.pix.fr |
lionelB
force-pushed
the
fix/multi-select-icon-position
branch
from
b6a358d to
df8dfbc
Compare
lionelB
added
👀 Design Review Needed
👀 Func Review Needed
👀 Tech Review Needed
cross-team
lionelB
force-pushed
the
fix/multi-select-icon-position
branch
from
df8dfbc to
0f7b74c
Compare
|
Test fonctionnel ok sur la Review App : Avant :
Après :
|
HEYGUL
approved these changes
Apr 4, 2024
xav-car
approved these changes
Apr 4, 2024
lionelB
force-pushed
the
fix/multi-select-icon-position
branch
from
0f7b74c to
cf689be
Compare
lionelB
changed the title
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Apr 4, 2024
## [45.0.4](v45.0.3...v45.0.4) (2024-04-04) ### 🐛 Correction - [#590](#590) corrige la position du chevron dans le multiselect (pix-11962)
|
🎉 This PR is included in version 45.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
L'icon chevron du composant multiselect est recouvert par le texte quand celui-ci est un peu long.
🎁 Proposition
On évite que le texte recouvre l'icone
🌟 Remarques
Etant donnée que le layout du bouton est flex, j'ai simplement rajouté une propriété
gap: var(--pix-space-1x);et remis l'icon dans le flux. On aurait pu aussi mettre un padding à droite plus important mais cela aurait donnée lié à des calculs plus compliqués pour que le padding tombe juste.🎅 Pour tester
Ouvrir le composant multiselect et valider que l'icon n'est pas recouvert par le texte