[TECH] Affiche toutes les icônes dans la story de PixIcon #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr738.review.pix.fr |
lionelB
force-pushed
the
add-all-icon-pix-icon-story
branch
from
bb4afd3 to
af51562
Compare
lionelB
changed the title
lionelB
force-pushed
the
add-all-icon-pix-icon-story
branch
2 times, most recently
from
33791e1 to
fb9eea0
Compare
lionelB
added
👀 Func Review Needed
👀 Tech Review Needed
and removed
🚧 Development in progress
Jeyffrey
reviewed
Oct 8, 2024
Jeyffrey
changed the title
Jeyffrey
changed the title
lionelB
force-pushed
the
add-all-icon-pix-icon-story
branch
2 times, most recently
from
1b1d6d6 to
cde748c
Compare
Jeyffrey
reviewed
Oct 9, 2024
|
|
||
| ## Usage | ||
|
|
||
| ```html | ||
| <PixIcon @name="powerSettings", @plainIcon={{true}} /> |
There was a problem hiding this comment.
Y a une virgule en trop entre les 2 paramètres
|
Cool d'avoir la liste :) Possible d'agrandir la largeur ? J'ai les icônes tout à droite coupés 
|
AndreiaPena
approved these changes
Oct 9, 2024
lionelB
force-pushed
the
add-all-icon-pix-icon-story
branch
from
cde748c to
435c183
Compare
lionelB
force-pushed
the
add-all-icon-pix-icon-story
branch
from
435c183 to
87febfc
Compare
|
@AndreiaPena c'est corrigé, merci ! |
lionelB
added
Func Review OK
Tech review OK
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
Jeyffrey
approved these changes
Oct 9, 2024
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Oct 9, 2024
## [46.15.1](v46.15.0...v46.15.1) (2024-10-09) ### 🏗️ Tech - [#738](#738) Affiche toutes les icônes dans la story de PixIcon
|
🎉 This PR is included in version 46.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
C'est pénible de ne pas avoir la liste de toutes les icônes disponibles dans la story du composant.
🎁 Proposition
On affiche toutess les icônes dispo
🌟 Remarques
J'aime travailler avec storybook
🎅 Pour tester
Afficher la story de PixIcon