-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Afficher un simulateur dans Modulix (PIX-13092) #9488
Merged
pix-service-auto-merge
merged 9 commits into
dev
from
pix-13092-display-embed-into-modulix
Jul 22, 2024
+431
−37
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
19ffe14
feat(mon-pix): add new embed component
reibecca c54f3d5
feat(mon-pix): handle embed in element component
reibecca 9284b01
feat(mon-pix): display embed into grain
reibecca 543b8b7
feat(mon-pix): add reset button
dlahaye 2ca5904
refactor(api): remove default required from htmlSchema
reibecca 1f59c2b
feat(api): add optional embed instruction
reibecca 4af5452
feat(mon-pix): display embed instruction when given
reibecca d284abe
feat(api): use a more recent embed in the referential
dlahaye 8166c38
feat(mon-pix): Add css variable to hide embed
theotime2005 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(mon-pix): add reset button
Co-authored-by: Rébecca Kaci <[email protected]>
- v5.45.0
- v5.44.0
- v5.43.0
- v5.42.0
- v5.41.0
- v5.40.0
- v5.39.0
- v5.38.0
- v5.37.0
- v5.36.0
- v5.35.0
- v5.34.0
- v5.33.0
- v5.32.0
- v5.31.0
- v5.30.0
- v5.29.0
- v5.28.0
- v5.27.0
- v5.26.0
- v5.25.0
- v5.24.0
- v5.23.0
- v5.22.0
- v5.21.0
- v5.20.0
- v5.19.0
- v5.18.0
- v5.17.0
- v5.16.0
- v5.15.0
- v5.14.0
- v5.13.0
- v5.12.0
- v5.11.0
- v5.10.0
- v5.9.0
- v5.8.0
- v5.7.0
- v5.6.0
- v5.5.0
- v5.4.0
- v5.3.0
- v5.2.0
- v5.1.0
- v5.0.0
- v4.253.0
- v4.252.0
- v4.251.0
- v4.250.1
- v4.250.0
- v4.249.0
- v4.248.0
- v4.247.0
- v4.246.0
- v4.245.0
- v4.244.0
- v4.243.0
- v4.242.0
- v4.241.0
- v4.240.0
- v4.239.0
- v4.238.0
- v4.237.0
- v4.236.0
- v4.235.0
- v4.234.0
- v4.233.0
- v4.232.0
- v4.231.0
- v4.230.0
- v4.229.1
- v4.229.0
- v4.228.0
- v4.227.0
- v4.226.0
- v4.225.0
- v4.224.0
- v4.223.0
- v4.222.0
- v4.221.0
- v4.220.0
- v4.219.0
- v4.218.0
- v4.217.0
- v4.216.0
- v4.215.0
- v4.214.0
- v4.213.0
- v4.212.0
- v4.211.0
- v4.210.1
- v4.210.0
- v4.209.0
- v4.208.1
- v4.208.0
- v4.207.0
- v4.206.0
- v4.205.0
- v4.204.0
- v4.203.0
- v4.202.0
- v4.201.0
- v4.200.0
- v4.199.0
- v4.198.0
- v4.197.0
- v4.196.0
- v4.195.0
- v4.194.0
- v4.193.0
- v4.192.0
- v4.191.0
- v4.190.0
- v4.189.0
- v4.188.0
- v4.187.0
- v4.186.0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,4 +24,9 @@ | |
height: 100%; | ||
background-color: rgb(0 0 0 / 55%); | ||
} | ||
|
||
&__reset { | ||
display: flex; | ||
justify-content: flex-end; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
import { setupTest } from 'ember-qunit'; | ||
import { module, test } from 'qunit'; | ||
import sinon from 'sinon'; | ||
|
||
import createGlimmerComponent from '../../../helpers/create-glimmer-component'; | ||
|
||
module('Unit | Component | Module | Embed', function (hooks) { | ||
setupTest(hooks); | ||
|
||
module('#setIframeHtmlElement', function () { | ||
test('should set the iframe html element', async function (assert) { | ||
// given | ||
const embed = { | ||
id: 'id', | ||
title: 'title', | ||
isCompletionRequired: false, | ||
url: 'https://embed-pix.com', | ||
height: 800, | ||
}; | ||
const component = createGlimmerComponent('module/element/embed', { | ||
embed, | ||
}); | ||
const expectedComponentIFrame = Symbol('iframeHtmlElement'); | ||
|
||
// when | ||
component.setIframeHtmlElement(expectedComponentIFrame); | ||
|
||
// then | ||
assert.deepEqual(component.iframe, expectedComponentIFrame); | ||
}); | ||
}); | ||
|
||
module('#resetEmbed', function () { | ||
test('should update the iframe src', async function (assert) { | ||
// given | ||
const embed = { | ||
id: 'id', | ||
title: 'title', | ||
isCompletionRequired: false, | ||
url: 'https://embed-pix.com', | ||
height: 800, | ||
}; | ||
const component = createGlimmerComponent('module/element/embed', { | ||
embed, | ||
}); | ||
component.iframe = { | ||
setAttribute: sinon.stub(), | ||
focus: sinon.stub(), | ||
}; | ||
|
||
// when | ||
component.resetEmbed(); | ||
|
||
// then | ||
sinon.assert.calledWith(component.iframe.setAttribute, 'src', embed.url); | ||
sinon.assert.called(component.iframe.focus); | ||
assert.ok(true); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah curieux de savoir l'histoire de ce modifier, on a une montée de version bloquée sur le même genre de sujet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yannbertrand c'est expliqué dans cette PR #9455 ;)