Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename TentapUtils.h call on TenTapViewImpl #161

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: rename TentapUtils.h call on TenTapViewImpl #161

merged 1 commit into from
Jul 11, 2024

Conversation

fahrulalwan
Copy link
Contributor

Continuing on #150 , i recently update the app to version 0.5.11. but i notice there is an import left behind on TentapUtils.h at TenTapViewImpl.mm. please re-check.

The following build commands failed:
	CompileC /Users/user/Library/Developer/Xcode/DerivedData/Project-dngdlqbebhvoynewnrxrduhaytpb/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/tentap.build/Objects-normal/arm64/TenTapViewImpl.o /Users/user/Workspaces/Project/project/node_modules/@10play/tentap-editor/ios/TenTapViewImpl.mm normal arm64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'tentap' from project 'Pods')
(1 failure)

17Amir17
17Amir17 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@17Amir17 17Amir17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have not installed pods before testing, thanks for the followup
LGTM

@17Amir17 17Amir17 merged commit ccf615f into 10play:main Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17Amir17 17Amir17 17Amir17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fahrulalwan @17Amir17