Merge pull request #282 from 10up/enhancement/193

Replace custom build process with WP-Scripts

.distignore

@@ -23,4 +23,3 @@ phpcs.xml
 phpunit.xml
 README.md
 webpack.config.js
-webpack.gutenberg.config.js

.github/workflows/build-release-zip.yml

@@ -53,9 +53,7 @@ jobs:
         run: composer install --no-dev
 
       - name: Build plugin
-        run: |
-          npm run build
-          npm run build:externals
+        run: npm run build
 
       - name: Generate ZIP file
         uses: 10up/action-wordpress-plugin-build-zip@stable

.github/workflows/deploy-to-wpdotorg.yml

@@ -13,7 +13,6 @@ jobs:
       run: |
         npm install
         npm run build
-        npm run build:externals
         composer install -o --no-dev --ignore-platform-reqs
     - name: WordPress Plugin Deploy
       id: deploy

.github/workflows/eslint.yml

@@ -23,4 +23,4 @@ jobs:
     - name: npm install
       run: npm install
     - name: Run eslint
-      run: npm run lint
+      run: npm run lint:js

.github/workflows/update-wpdororg-assets.yml

@@ -14,7 +14,6 @@ jobs:
       run: |
         npm install
         npm run build
-        npm run build:externals
         composer install -o --no-dev --ignore-platform-reqs
     - name: WordPress.org plugin asset/readme update
       uses: 10up/action-wordpress-plugin-asset-update@stable

assets/css/admin-autoshare-for-twitter.css

@@ -87,7 +87,7 @@ span.over-limit {
 /* Styling for post columns */
 .fixed .column-is_tweeted {
 	width: 50px;
-	vertical-align: middle;
+	vertical-align: top;
 }
 
 .fixed .column-is_tweeted a {

includes/admin/assets.php

@@ -111,35 +111,6 @@ function maybe_enqueue_classic_editor_assets( $hook ) {
 		return;
 	}
 
-	$api_fetch_handle = 'wp-api-fetch';
-	if ( ! wp_script_is( $api_fetch_handle, 'registered' ) ) {
-		wp_register_script(
-			$api_fetch_handle,
-			trailingslashit( AUTOSHARE_FOR_TWITTER_URL ) . 'dist/api-fetch.js',
-			[],
-			'3.4.0',
-			true
-		);
-
-		wp_add_inline_script(
-			$api_fetch_handle,
-			sprintf(
-				'wp.apiFetch.use( wp.apiFetch.createNonceMiddleware( "%s" ) );',
-				( wp_installing() && ! is_multisite() ) ? '' : wp_create_nonce( 'wp_rest' )
-			),
-			'after'
-		);
-
-		wp_add_inline_script(
-			$api_fetch_handle,
-			sprintf(
-				'wp.apiFetch.use( wp.apiFetch.createRootURLMiddleware( "%s" ) );',
-				esc_url_raw( get_rest_url() )
-			),
-			'after'
-		);
-	}
-
 	$handle = 'admin_autoshare_for_twitter_classic_editor';
 	wp_enqueue_script(
 		$handle,
@@ -168,10 +139,11 @@ function enqueue_editor_assets() {
 		return;
 	}
 
-	wp_enqueue_script(
-		SCRIPT_HANDLE,
-		trailingslashit( AUTOSHARE_FOR_TWITTER_URL ) . 'dist/autoshare-for-twitter.js',
-		[
+	$asset_file = AUTOSHARE_FOR_TWITTER_PATH . '/dist/autoshare-for-twitter.asset.php';
+	// Fallback asset data.
+	$asset_data = array(
+		'version'      => AUTOSHARE_FOR_TWITTER_VERSION,
+		'dependencies' => array(
 			'lodash',
 			'wp-components',
 			'wp-compose',
@@ -180,8 +152,18 @@ function enqueue_editor_assets() {
 			'wp-element',
 			'wp-i18n',
 			'wp-plugins',
-		],
-		AUTOSHARE_FOR_TWITTER_VERSION,
+			'wp-primitives',
+		),
+	);
+	if ( file_exists( $asset_file ) ) {
+		$asset_data = require $asset_file;
+	}
+
+	wp_enqueue_script(
+		SCRIPT_HANDLE,
+		trailingslashit( AUTOSHARE_FOR_TWITTER_URL ) . 'dist/autoshare-for-twitter.js',
+		$asset_data['dependencies'],
+		$asset_data['version'],
 		true
 	);