upkeep: add TS support for useIsPluginActive hook
#297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -7 B (0%) Total Size: 65.7 kB
|
Sidsector9
commented
Mar 1, 2024
fabiankaegy
reviewed
Mar 1, 2024
hooks/use-is-plugin-active/index.ts
Outdated
|
|
||
| const isPluginActive: boolean = ACTIVE_STATUSES.includes(plugin?.status); | ||
|
|
||
| return [isPluginActive, hasResolvedPlugins] as [boolean, boolean]; |
There was a problem hiding this comment.
Why is the as required here? Shouldn't it already know that due yo the earlier types?
There was a problem hiding this comment.
Ahh that is because you manually typed the return of the function. We can leave that off. It can get inferred :)
There was a problem hiding this comment.
I've still moved that logic here 7c5ee73 for clarity.
1 failed test on run #758 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| IconPicker > allows the user to use the post picker to change an icon and displays it |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #297 ↗︎
Sidsector9
force-pushed
the
upkeep/use-is-plugin-active
branch
from
1865da5 to
7c5ee73
Compare
…omponents into upkeep/use-is-plugin-active
Sidsector9
commented
Mar 1, 2024
Sidsector9
changed the title
useIsPluginActive hook
fabiankaegy
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Converts the useIsPluginActive hook to TypeScript.
Closes #
How to test the Change
Changelog Entry
Credits
Props @fabiankaegy @Sidsector9
Checklist: