Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add editor-style entrypoint #178

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

davisshaver
Copy link
Contributor

Description of the Change

Checkout branch and build

Load New Post page with plugin enabled. Do not have SCRIPT_DEBUG enabled. Do not observe the 404.

Closes #174

How to test the Change

Changelog Entry

Fixed: Build editor-style entrypoint

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@davisshaver davisshaver marked this pull request as ready for review January 15, 2024 13:31
@davisshaver
Copy link
Contributor Author

I could use some help with reviewing and verifying this fix. After looking at it more closely, it kind of seems like this was never working for either dev/debug or prod modes. So I wonder if we even need this stylesheet loaded?

@jeffpaul jeffpaul added this to the 1.3.4 milestone Jan 16, 2024
includes/core.php Outdated Show resolved Hide resolved
@jeffpaul jeffpaul removed their request for review January 16, 2024 22:18
@davisshaver davisshaver requested a review from dkotter January 17, 2024 14:22
@dkotter dkotter merged commit 72cf7f6 into 10up:develop Jan 17, 2024
11 of 12 checks passed
@davisshaver davisshaver deleted the add-editor-style-entrypoint branch May 20, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor Stylesheet does not need to be loaded outside of SCRIPT_DEBUG mode
3 participants