Adjust frontend styles to be compatible with latest core themes #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR addresses styling issues found on the latest Core theme and WordPress version in issue #138
Some of the issues I did not find and others I felt did not need to be addressed.
I tested on Twenty Twenty Four, Twenty Twenty Three, Twenty Twenty Two, and Twenty Twenty on WordPress 6.5
1 - Spacing issue on 'Audience Profiles' Section
I did not see this issue and no changes were made.
2 - Spacing issue on 'Why you should choose digital' Section
I adjusted the top margin for this group as well as the interior padding on all four sides. I did not place the headings and icons inline as that can be done with a Row block in the editor.
3 - Font is different in all section
The font faces were all correct with what is being loaded on the site. The font sizes and color looked intentional in the stylesheets as well. I did not change anything related to this issue.
4 - Background color is missing in 'Our package' and 'Why you should choose digital' section
Our Packages does not have a background color nor does it have one in the CSS file that is not being targetted properly. I did not change this section.
Why Choose does have a background color and was left as-is. Look at the screenshot above in number 2. It is a very faint background color but it is there.
5 - Background colour is missing in table block
The even rows in the table do not have a background color or a text color the way odd rows do. Even though the existing styles look good on all tested themes, I went ahead and added a background color and text color based on the core present CSS variables just in case these colors are wildly different than the background color. To the naked eye, nothing looks to have changed.
6 - Still Have Questions Background Color
This section does have a background color although it is very faint. I did not change this section.
Closes #183
How to test the Change
Changelog Entry
Credits
Props @claytoncollie
Checklist: