Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WordPress "tested up to" version 6.7 #212

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Bump WordPress "tested up to" version 6.7 #212

merged 9 commits into from
Dec 13, 2024

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Nov 8, 2024

Description of the Change

@severine-pozzo confirmed in #211 (comment) that things passed in WordPress 6.7 testing, so this PR bumps to that version and drags forward the min version to 6.5.

Closes #211.

How to test the Change

Changelog Entry

Changed - Bump WordPress "tested up to" version 6.7
Changed - Bump WordPress minimum supported version to 6.5.

Credits

Props @severine-pozzo @jeffpaul.

Checklist:

@jeffpaul jeffpaul added this to the 1.3.6 milestone Nov 8, 2024
@jeffpaul jeffpaul requested a review from dkotter as a code owner November 8, 2024 20:34
@github-actions github-actions bot added the needs:code-review This requires code review. label Nov 8, 2024
@jeffpaul
Copy link
Member Author

jeffpaul commented Nov 8, 2024

@severine-pozzo looks like automated e2e tests failed on WP trunk (aka 6.7). Can you check and see if there's something perhaps not working on this version? cc: @faisal-alvi

@jeffpaul
Copy link
Member Author

@faisal-alvi can you help check out that failure?

@severine-pozzo
Copy link
Contributor

severine-pozzo commented Nov 12, 2024 via email

/home/runner/work/publisher-media-kit/publisher-media-kit/tests/cypress/integration/pmk-block-patterns.test.js
Error:    1:1   error  'describe' is not defined                                                                                                                                                                                                                                                                                                                               no-undef
Error:    2:1   error  Replace `····` with `↹`                                                                                                                                                                                                                                                                                                                                 prettier/prettier
Error:    2:5   error  'it' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:    3:1   error  Replace `········` with `↹↹`                                                                                                                                                                                                                                                                                                                            prettier/prettier
Error:    3:9   error  'cy' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:    4:1   error  Replace `········` with `↹↹`                                                                                                                                                                                                                                                                                                                            prettier/prettier
Error:    4:9   error  'cy' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:    5:1   error  Replace `········cy.get('#post-title-0,·h1.editor-post-title__input').click(·{·force:·true·}·)` with `↹↹cy.get('#post-title-0,·h1.editor-post-title__input')⏎↹↹↹.click({·force:·true·})⏎↹↹↹`                                                                                                                                                            prettier/prettier
Error:    5:9   error  'cy' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:    6:1   error  Replace `········cy.get('.edit-post-header-toolbar__inserter-toggle,·.editor-document-tools__inserter-toggle'` with `↹↹cy.get(⏎↹↹↹'.edit-post-header-toolbar__inserter-toggle,·.editor-document-tools__inserter-toggle',⏎↹↹`                                                                                                                            prettier/prettier
Error:    6:9   error  'cy' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:    7:1   error  Replace `········cy.get('.components-tab-panel__tabs·button,·.block-editor-inserter__tabs·button,·.block-editor-tabbed-sidebar__tablist·button').contains(·'Patterns'·)` with `↹↹cy.get(⏎↹↹↹'.components-tab-panel__tabs·button,·.block-editor-inserter__tabs·button,·.block-editor-tabbed-sidebar__tablist·button',⏎↹↹)⏎↹↹↹.contains('Patterns')⏎↹↹↹`  prettier/prettier
Error:    7:9   error  'cy' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:    9:1   error  Replace `········` with `↹↹`                                                                                                                                                                                                                                                                                                                            prettier/prettier
Error:   10:1   error  Replace `········` with `↹↹`                                                                                                                                                                                                                                                                                                                            prettier/prettier
Error:   10:9   error  'cy' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:   11:1   error  Replace `············` with `↹↹↹`                                                                                                                                                                                                                                                                                                                       prettier/prettier
Error:   12:1   error  Replace `················` with `↹↹↹↹`                                                                                                                                                                                                                                                                                                                  prettier/prettier
Error:   12:17  error  'cy' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:   13:1   error  Replace `····················` with `↹↹↹↹↹`                                                                                                                                                                                                                                                                                                             prettier/prettier
Error:   14:1   error  Replace `················` with `↹↹↹↹`                                                                                                                                                                                                                                                                                                                  prettier/prettier
Error:   15:1   error  Replace `············}·else·if·($body.find(·'[aria-label="Publisher·Media·Kit"]'·` with `↹↹↹}·else·if·($body.find('[aria-label="Publisher·Media·Kit"]'`                                                                                                                                                                                                 prettier/prettier
Error:   16:1   error  Replace `················` with `↹↹↹↹`                                                                                                                                                                                                                                                                                                                  prettier/prettier
Error:   16:17  error  'cy' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:   17:1   error  Replace `············` with `↹↹↹`                                                                                                                                                                                                                                                                                                                       prettier/prettier
Error:   19:1   error  Replace `············` with `↹↹↹`                                                                                                                                                                                                                                                                                                                       prettier/prettier
Error:   20:1   error  Replace `············` with `↹↹↹`                                                                                                                                                                                                                                                                                                                       prettier/prettier
Error:   20:13  error  'cy' is not defined                                                                                                                                                                                                                                                                                                                                     no-undef
Error:   21:1   error  Replace `········` with `↹↹`                                                                                                                                                                                                                                                                                                                            prettier/prettier
Error:   22:1   error  Replace `····` with `↹`                                                                                                                                                                                                                                                                                                                                 prettier/prettier
@faisal-alvi faisal-alvi merged commit a6a2476 into develop Dec 13, 2024
11 checks passed
@faisal-alvi faisal-alvi deleted the bump/wp-ver branch December 13, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with the latest version of WordPress
3 participants