Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text domain is forgotten for a button and two text fields #337

Closed
1 task done
NekoJonez opened this issue Nov 26, 2024 · 0 comments · Fixed by #338
Closed
1 task done

Text domain is forgotten for a button and two text fields #337

NekoJonez opened this issue Nov 26, 2024 · 0 comments · Fixed by #338
Assignees
@NekoJonez
Labels
type:bug Something isn’t working.
Milestone
7.6.0

Comments

@NekoJonez
Copy link
Contributor

NekoJonez commented Nov 26, 2024 •
edited
Loading

Describe the bug

The text domain is forgotten for one of the buttons/two textboxes in the admin panel. This causes a button that makes it untranslate-able by translators.

Steps to Reproduce

See the screenshot of the settings page. It's just shown in the settings page. It doesn't appear in the .PO file.

Screenshots, screen recording, code snippet

Image

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@NekoJonez NekoJonez added the type:bug Something isn’t working. label Nov 26, 2024
@NekoJonez NekoJonez changed the title Text domain is forgotten for a button Text domain is forgotten for a button and two text field Nov 26, 2024
@NekoJonez NekoJonez changed the title Text domain is forgotten for a button and two text field Text domain is forgotten for a button and two text fields Nov 26, 2024
@NekoJonez NekoJonez mentioned this issue Nov 26, 2024
Merged
@vikrampm1 vikrampm1 moved this to Code Review in Open Source Practice Nov 26, 2024
@vikrampm1 vikrampm1 added this to the 7.6.0 milestone Nov 26, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Done in Open Source Practice Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NekoJonez NekoJonez

Labels
type:bug Something isn’t working.
Projects
Open Source Practice
Status: Done
Milestone
7.6.0
Development

Successfully merging a pull request may close this issue.

Fix missing text domain NekoJonez/restricted-site-access
2 participants
@NekoJonez @vikrampm1