Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing text domain #338

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix missing text domain #338

merged 1 commit into from
Nov 26, 2024

Conversation

NekoJonez
Copy link
Contributor

This would fix #337

I used Loco Translate to test this on a local website. So, this is before:

image

And after I applied this patch, made a new template and translate the new text lines:

image

@vikrampm1 vikrampm1 added this to the 7.6.0 milestone Nov 26, 2024
@jeffpaul jeffpaul requested review from Sidsector9 and removed request for dkotter and jeffpaul November 26, 2024 15:29
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@dkotter dkotter merged commit 9ddb1c4 into 10up:develop Nov 26, 2024
11 of 12 checks passed
@NekoJonez NekoJonez deleted the patch-1 branch November 27, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text domain is forgotten for a button and two text fields
3 participants