Don't create duplicate image sizes #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
faisal-alvi
and removed request for
dkotter and
jeffpaul
faisal-alvi
requested changes
Jan 29, 2025
faisal-alvi
requested changes
Feb 7, 2025
There was a problem hiding this comment.
@ocean90 Thanks for the fix! Could you take a look at why the PHPUnit and Cypress tests started failing? Also, I’ve added a couple of minor suggestions below.
Co-authored-by: Faisal Alvi <[email protected]>
faisal-alvi
approved these changes
Feb 7, 2025
| $resized = $editor->resize( $size, $size, true ); | ||
| if ( ! is_wp_error( $resized ) ) { | ||
| $dest_file = $editor->generate_filename(); | ||
| $saved = $editor->save( $dest_file ); |
There was a problem hiding this comment.
I know this isn't new code, but do you think we should account for the case where generate_filename() returns false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Check size of original image before creating a duplicate version of it.
Closes #323
How to test the Change
Upload an image of an avatar size that is used on the site. Ensure that no version is created for this size.
Changelog Entry
Credits
Props @ocean90
Checklist: