feat: add WS station fetcher #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to fix simplePositioner cursedness with threading
NuttyShrimp
force-pushed
the
station-ws-conn
branch
from
9c140bf
to
affe45c
Compare
FKD13
reviewed
Apr 14, 2024
build.gradle
Outdated
|
|
||
| // Websocket client libs | ||
| compileOnly 'jakarta.websocket:jakarta.websocket-client-api:2.2.0-M1' | ||
| implementation 'org.glassfish.tyrus.bundles:tyrus-standalone-client:2.2.0-M1' |
There was a problem hiding this comment.
What does this dependency provide?
There was a problem hiding this comment.
It adds implementation for some jakarta classes, I've replaced it with the jersey one to make it more in line with the impl's we are using for our ws server
is more in line with what we use for our server impl
xerbalind
requested changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds another fetcher for the stations, the new one uses websockets to connect to the station.
Telraam chooses the right fetcher based on the scheme of the URL defined in the DB.
I've found out the simplePositioner is not a fan of the multi threading and start panicking with out-of-bound errors after some data has been put in its list. I've opened a new issue as this is something out of scope for this PR
closes #127