Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: use uv pip compile to keep minimal deps in sync #129

Merged

Conversation

neutrinoceros
Copy link
Collaborator

No description provided.

@neutrinoceros neutrinoceros force-pushed the tests/simplify_devdeps_install branch from e232fd5 to 4cd9cf4 Compare March 1, 2024 10:38
@neutrinoceros
Copy link
Collaborator Author

I need to figure out how to actually pin numpy==1.19.3
Right now the "minimal" env is still using numpy 1.26

@neutrinoceros neutrinoceros force-pushed the tests/simplify_devdeps_install branch from bf3e9f1 to dd9c300 Compare March 1, 2024 11:20
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (554d1d0) to head (2d8757f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   98.52%   98.37%   -0.15%     
==========================================
  Files           6        6              
  Lines         676      676              
==========================================
- Hits          666      665       -1     
- Misses         10       11       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neutrinoceros neutrinoceros force-pushed the tests/simplify_devdeps_install branch from 664d246 to 40a3345 Compare March 1, 2024 12:17
@neutrinoceros neutrinoceros force-pushed the tests/simplify_devdeps_install branch from bf0097d to 2d8757f Compare March 1, 2024 12:23
@neutrinoceros neutrinoceros marked this pull request as ready for review March 1, 2024 12:23
@neutrinoceros
Copy link
Collaborator Author

I learned that minimal env was actually not tested before that PR, and was slightly broken. I made an effort to fix it but resorted to bumping the minimal supported numpy version instead (following SPEC 0).

@neutrinoceros neutrinoceros merged commit 4f9a1b5 into 1313e:master Mar 1, 2024
22 of 24 checks passed
@neutrinoceros neutrinoceros deleted the tests/simplify_devdeps_install branch March 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant