-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility contrast bug on "our work" page with Chrome #3796
Comments
Seems to be an issue with the "followed link" color. |
I can certainly look, but offhand to we know if this is a Design System issue or local only to this page? And if so, should we prioritize a quick-local fix first? |
Thinking aloud as I investigate. The link is classed like it's on a dark background (it doesn't seem to know it's on a light button); so that's a thing. I'll look into how widespread that is or if it just needs an additional class |
It also isn't a button at all, at least in code, and this seems like one of those semantic edge cases |
Scratch that, it is a |
Same issue also happens on the homepage in the "What 18F can do" and "Recent blog posts" sections, so I suspect any buttons on dark backgrounds would see this effect |
So for this site, it seems we implemented an 18F specific button class, |
Expected Behavior
Contrasting colors on the "get in touch" button at this url: https://18f.gsa.gov/our-work/
Actual Behavior
This is my screen shot using chrome:
Steps to reproduce the behavior
I only get this issue with Chrome, it looks correct in Safari.
I tried clearing my cache and re-launching Chrome, but the issue persists for me. I don't see any errors in the inspector on page load.
It is possible it's just something weird locally for me, feel free to close the issue if you can't reproduce it. I wanted to file an issue just in case this is also happening to others.
This issue is done when
Thank you!!
The text was updated successfully, but these errors were encountered: