Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility contrast bug on "our work" page with Chrome #3805

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

dluetger
Copy link
Contributor

@dluetger dluetger commented Feb 7, 2024

Fixes #3796

Pull request summary

(Optional) Closes #(issue_number).

Reminder - please do the following before assigning reviewer

  • update readme
  • For frontend changes, ensure design review

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introdcued

@dluetger
Copy link
Contributor Author

dluetger commented Feb 8, 2024

Made this to test a change but I believe that change is working so let's make this PR official I suppose. This edits button.scss to include the proper visited state for the an18F-button--accent class

Copy link
Member

@juliaklindpaintner juliaklindpaintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, Dave!

Copy link
Contributor

@cannandev cannandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cannandev cannandev merged commit b042fcf into main Feb 9, 2024
2 checks passed
@cannandev cannandev deleted the dluetger/issue3796 branch February 9, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility contrast bug on "our work" page with Chrome
3 participants