Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates and Node.js LTS update #559

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

mgwalker
Copy link
Contributor

@mgwalker mgwalker commented Nov 13, 2024

Just what it says.

  • The Bolt API made one breaking change for us: the directMention middleware was changed that instead of needing to call a function to obtain it, the middleware is returned directly. So directMention() was changed to directMention in our code.
  • The updated Prettier wanted parentheses around the return value of a ternary (q-expand.js).
  • Updating to eslint@^9 is a whole thing. The config file format changed. It should be done, but there's no particular rush. The new config format looks a lot cleaner so that's great, though.
  • Updating to the AWS JS SDK version 3 is a priority because version 2 hits EOL in March or so. It's not much of a lift, but does require a bit of rework of the hugme bot, which possibly ought to be deprecated anyway.

Checklist:

  • Code has been formatted with prettier
  • All the rest are N/A

@mgwalker mgwalker marked this pull request as ready for review November 13, 2024 21:47
@mgwalker mgwalker requested a review from a team as a code owner November 13, 2024 21:47
@mgwalker mgwalker merged commit a62f092 into main Nov 20, 2024
7 checks passed
@mgwalker mgwalker deleted the dependency-updates branch November 20, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant