This repository has been archived by the owner on Dec 8, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
User requested changes to JSON Schema #200
Open
scottdchristian
wants to merge
13
commits into
18F:master
Choose a base branch
from
scottdchristian:Registration-steps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Trello user requested changes to JSON Schema
Changed the descriptions to make them more clear and changed the flow of the manifest items to make them more in sync with the manifest form. No new fields were added
Changed name of emergency response manual to guidebook
Fixed typo in line 162. Changed "handler_defined_dataum_item to "handler_defined_data_item
Fixed 3 of my errors in JSON Schema and escaped 2 phone number patterns. Errors are highlighted in the attached file, two were referential, the other was an improperly placed object. Per industry and developer request using code from our developer escaped the phone number patterns.
Changes to state Waste codes to ensure the object is collecting the correct data.
Grammatical change to report_management_method_code. The code currently named Grammatical change to report_management_method_code was named report_management_method_codes. Since there is one code per line a plural name does not make sense.
changed "date_entry_exit_us" back to "date_exit_us"
Begining of adding optional, conditionally required, and required tags
Added new fields as related to the e-Manifest front end. provide_BR_information paper_manifest_tracking_number status is_international_shipment discrepancy_present
Added Additional DOT Information
Added Phone number Extension fields
Fixed typo on line 241 from Fixed typo on line 241 telephone_number_extension to telephone_number_extension_data_type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Trello user requested changes to JSON Schema