This repository has been archived by the owner on Dec 8, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For getting initial feedback
Looks great so far! Have you been able to generate the docs successfully? Does gap analysis give you information that makes sense? |
@afeld re gap analysis -- I don't see any difference in the list (25 missing controls) after adding AC-2. Do I need a "implementation_status"? If so, what is there a set of values I should be using? |
Though these may be removed
Not sure...is the problem described in opencontrol/schemas#24?
|
@afeld Thanks! I'll keep plugging away |
Per @tadhg-ohiggins' suggestions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial documentation for our controls -- used in the ATO.