Skip to content

Commit

Permalink
Fix spec failures in rc-2017-04-06 (#1329)
Browse files Browse the repository at this point in the history
* Fix OIDC spec failures in rc-2017-04-06

**Why**:
The specs referenced a table on master that is not
available on the branch yet

* Add missing translation key

**Why**: Difference between RC branch and master

* Inline the <style> attribute

**Why**: Fix rendering in IE due to CSP
  • Loading branch information
zachmargolis authored Apr 6, 2017
1 parent 84e7fcd commit 202fc13
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app/assets/images/up-carat.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions config/locales/notices/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ en:
session_cleared: >
For your security, we refresh the page and clear out any information you typed into the
form fields if you don't submit the form within %{minutes} minutes.
session_cleared_with_sp: >
For your security, your request from %{sp} expires after %{minutes} minutes if you don't
submit the form. Then you'll have to start again from %{link}.
signed_up_but_unconfirmed:
first_paragraph_end: >
with a link to confirm your email address. Follow the link to continue
Expand Down
1 change: 1 addition & 0 deletions config/locales/notices/es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ es:
sign_out: NOT TRANSLATED YET
message_html: NOT TRANSLATED YET
session_cleared: NOT TRANSLATED YET
session_cleared_with_sp: NOT TRANSLATED YET
signed_up_but_unconfirmed:
first_paragraph_end: NOT TRANSLATED YET
first_paragraph_start: NOT TRANSLATED YET
Expand Down
4 changes: 0 additions & 4 deletions spec/features/openid_connect/openid_connect_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@
prompt: 'select_account'
)

sp_request_id = ServiceProviderRequest.last.uuid
allow(FeatureManagement).to receive(:prefill_otp_codes?).and_return(true)
sign_in_user(user)

Expand All @@ -147,9 +146,6 @@
click_submit_default

expect(current_url).to start_with('http://localhost:7654/auth/result')
expect(ServiceProviderRequest.from_uuid(sp_request_id)).
to be_a NullServiceProviderRequest
expect(page.get_rack_session.keys).to_not include('sp')
end
end

Expand Down

0 comments on commit 202fc13

Please sign in to comment.