DRAFT: LG-12534 FSM clean up part 1

app/controllers/concerns/idv/step_indicator_concern.rb

@@ -20,13 +20,21 @@ module StepIndicatorConcern
       { name: :secure_account },
     ].freeze
 
+    STEP_INDICATOR_STEPS_IPP = [
+      { name: :find_a_post_office },
+      { name: :verify_info },
+      { name: :verify_phone },
+      { name: :re_enter_password },
+      { name: :go_to_the_post_office },
+    ].freeze
+
     included do
       helper_method :step_indicator_steps
     end
 
     def step_indicator_steps
       if in_person_proofing?
-        Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS
+        Idv::StepIndicatorConcern::STEP_INDICATOR_STEPS_IPP
       elsif gpo_address_verification?
         Idv::StepIndicatorConcern::STEP_INDICATOR_STEPS_GPO
       else

app/controllers/idv/by_mail/request_letter_controller.rb

@@ -59,11 +59,7 @@ def confirm_letter_sends_allowed
       end
 
       def step_indicator_steps
-        if in_person_proofing?
-          Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS_GPO
-        else
-          StepIndicatorConcern::STEP_INDICATOR_STEPS_GPO
-        end
+        StepIndicatorConcern::STEP_INDICATOR_STEPS_GPO
       end
     end
   end

app/controllers/idv/by_mail/resend_letter_controller.rb

@@ -83,11 +83,7 @@ def pii_locked?
       end
 
       def step_indicator_steps
-        if in_person_proofing?
-          Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS_GPO
-        else
-          StepIndicatorConcern::STEP_INDICATOR_STEPS_GPO
-        end
+        StepIndicatorConcern::STEP_INDICATOR_STEPS_GPO
       end
     end
   end

app/controllers/idv/in_person_controller.rb

@@ -9,30 +9,25 @@ class InPersonController < ApplicationController
 
     before_action :confirm_two_factor_authenticated
     before_action :redirect_unless_enrollment
-
-    include IdvSessionConcern
-    include Flow::FlowStateMachine
-    include ThreatMetrixConcern
-
-    before_action :redirect_if_flow_completed
-
+    before_action :initialize_in_person_session
     before_action :set_usps_form_presenter
 
-    FLOW_STATE_MACHINE_SETTINGS = {
-      step_url: :idv_in_person_step_url,
-      final_url: :idv_in_person_state_id_url,
-      flow: Idv::Flows::InPersonFlow,
-      analytics_id: 'In Person Proofing',
-    }.freeze
+    def index
+      redirect_to idv_in_person_state_id_url
+    end
+
+    def update
+      redirect_to idv_in_person_state_id_url
+    end
 
     private
 
     def redirect_unless_enrollment
       redirect_to idv_url unless current_user.establishing_in_person_enrollment
     end
 
-    def redirect_if_flow_completed
-      flow_finish if idv_session.applicant
+    def initialize_in_person_session
+      user_session['idv/in_person'] ||= { pii_from_user: { uuid: current_user.uuid } }
     end
 
     def set_usps_form_presenter