Override CSP for ThreatMetrix based on feature-specific config #11678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etrix-call-to-mfa-selection
…etrix-call-to-mfa-selection
…etrix-call-to-mfa-selection
…etrix-call-to-mfa-selection
changelog: Upcoming Features, Anti-Fraud, Override CSP for ThreatMetrix based on feature-specific config
aduth
commented
Dec 19, 2024
There was a problem hiding this comment.
Easier to review this file with whitespace changes hidden: https://github.com/18F/identity-idp/pull/11678/files?w=1
matthinz
approved these changes
Dec 19, 2024
Base automatically changed from
LG-15203-move-threatmetrix-call-to-mfa-selection
to
main
December 23, 2024 16:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Supports LG-15302
🛠 Summary of changes
Moves feature flag check from shared
ThreatMetrixConcernto individual controllers, so that overriding CSP for account creation is not dependent on profiling collection being enabled for identity proofing.Temporarily merges to
LG-15203-move-threatmetrix-call-to-mfa-selectionas base, with intent to rebase againstmainonce #11654 is merged.📜 Testing Plan
Verify build passes.
Verify that CSP override occurs on MFA setup screen when account creation profiling collection is enabled and identity proofing device profiling collection is disabled.