LG-15314 | Replace 'partner agency' with SP name #11686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a misunderstanding with DOS, the translations had the literal string "service provider". Fixed! Conditionally hides the display if there is no SP (which shouldn't happen in prod) because otherwise the message is nonsense and has no clickable link text. changelog: User-Facing Improvements, Account screen, Show SP name in return-to-SP CTA
n1zyy
commented
Dec 23, 2024
jmhooper
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15314
🛠 Summary of changes
Due to a misunderstanding with the Department of State, the strings for a prompt redirecting users to their service provider when they hadn't connected their account to them used "partner agency" as a literal string rather than an interpolation.
This fixes that, and also omits the message in the case that the name is nil since it is otherwise incomprehensible and contains no link.
That required some test changes, and also led to a bit of refactoring. Shoutout to @jmhooper for encouraging that part.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After:
No SP name, so CTA not displayed:
(Otherwise it would read "Connect your account to. Sign in to to access services.")
English:
Spanish:
French:
Chinese (simplified):
