Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leaks from macOS clipboard getters #106

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Remove leaks from macOS clipboard getters #106

merged 1 commit into from
Aug 28, 2023

Commits on Aug 24, 2023

  1. Remove leaks from macOS clipboard getters 

    This additionally refactors `image()` to be simpler by taking advantage
of the fact that we only want one image. Additionally, this codepath avoids
the system-level caching of image data that can help reduce peak usage.
We have applied an autorelease pool to the Obj-C code as well, as there
appear to be a lot of autoreleased values used by AppKit.framework

Finally, it applies a similar refactoring to `text()` for simplicity and
removal of memory leaks due to incorrect object retaining assumptions.

Co-authored-by: taojiacheng <[email protected]>
    @complexspaces @ChurchTao
    complexspaces and ChurchTao committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    aef19b9 View commit details
    Browse the repository at this point in the history