Update windows-sys version compatibility #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR technically updates
windows-sys
, but more importantly it makes some changes to allowarboard
to work with either0.52
(more common) or0.59
versions of the crate. This change's goal is to make it easier to balance the desires of parties who want the latest version in their tree (and to help the ecosystem move along) with those who are stuck with older versions and don't want their build times or lockfiles damaged.It accomplishes this via three parts:
windows.rs
module to abstract over some function parameter and return value changes that have been made in the past.arboard
'sCargo.toml
0.52
which would break downstream builds. This is the most important part as it helps verify our code is actually compatible with this version range.The idea is based off many similar changes being made across crates.io, including winapi-util, errno, is-terminal, and many others to reduce version churn for users.