Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for windows runner #4

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

szzsolt
Copy link

@szzsolt szzsolt commented Oct 26, 2023

This PR adds support for running the action on windows runners. It includes:

  • powershell script to install op, following the same logic as the original shell script
  • powershell test script modelled after the original bash version
  • changes to the .yml files to run the powershell script when running on windows
  • updated README

@edif2008
Copy link
Member

It looks like your commits are not signed. A requirement of this repo is to have the commits signed.

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@edif2008
Copy link
Member

This is really exciting to see! Thank you so much for contributing with this enhancement! 💪🏻

@Jongveloper
Copy link

@edif2008
@szzsolt
I need to run actions on the window as soon as possible.
So, can I copy the contents of the PR and sign the commitment to post the PR?😢😢

@Natiq0
Copy link

Natiq0 commented Jun 12, 2024

+1

@szzsolt Any chance you will sign your commits?

@Jongveloper Did you manage to find a workaround? Did you re-post the PR with signed commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants