add example tests #151
Open
add example tests #151
+223
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOmarMiraj
reviewed
Nov 28, 2024
| itemParams := onepassword.ItemCreateParams{ | ||
| Title: "Login created with the SDK", | ||
| Category: onepassword.ItemCategoryLogin, | ||
| VaultID: vaultID, |
There was a problem hiding this comment.
can't this directly be here?
Suggested change
| VaultID: vaultID, | |
| VaultID: os.Getenv("CORE_SDK_TEST_VAULT_ID"), |
MOmarMiraj
reviewed
Nov 28, 2024
| // [developer-docs.sdk.go.resolve-secret]-start | ||
| // Retrieves a secret from 1Password. | ||
| // Takes a secret reference as input and returns the secret to which it points. | ||
| secret, err := client.Secrets.Resolve(context.Background(), secretRef) |
There was a problem hiding this comment.
Remove L109 and.
Suggested change
| secret, err := client.Secrets.Resolve(context.Background(), secretRef) | |
| secret, err := client.Secrets.Resolve(context.Background(), os.GetEnv("CORE_SDK_TEST_SECRET_REF") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR duplicate the existing examples folder that we frequently use as tests, and modify it so that they fetch the test secret reference and vault id from env vars, making testing wtih the examples much, much easier.