-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG FIX] Remove ngrok version check everytime a op plugin command is called #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm apart from the wording suggestion
f87e9af
to
20ca75f
Compare
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
…l_request_target:` Signed-off-by: Omar Miraj <[email protected]>
Signed-off-by: Omar Miraj <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0. - [Commits](golang/net@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Omar Miraj <[email protected]>
Signed-off-by: Omar Miraj <[email protected]>
Signed-off-by: Omar Miraj <[email protected]>
Signed-off-by: Omar Miraj <[email protected]>
0c0dc7d
to
e19db8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, and the changes make sense - calling the ngrok --version
command only when actually provisioning and not in the Provisioner's instantiation.
Haven't functionally tested.
Overview
This MR will fix a bug regarding
ngrok --version
being called on everyop plugin
command.Type of change
Related Issue(s)
How To Test
The test pipelines should pass as usual and when running an
op plugin
command, if you check the activity monitor.. there should be nongrok
processes. (Note: Must have the ngrok CLI installed to test this)Sometimes its hard to see the
ngrok
process on the activity monitor/task manager. An easier way to test is by changing L129 onplugins/ngrok/provisioner.go
to open up any application you have on your PC and see if the app opens up when you run aop plugin
command.Changelog
The op plugin commands do not call a ngrok version check even if the ngrok plugin is not initialized.