Moves op version check from provider initialization to before executing op commands #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @josh-burton ! Looks good. I'll prepare a beta release with that fix, so we can try it on Terraform Cloud. To be able to merge it the commit should be signed. Could you please sign it? |
josh-burton
force-pushed
the
op-version-check
branch
from
ebc4567 to
538c6e2
Compare
No problem, the commit should be signed now. |
volodymyrZotov
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #116.
The op cli may not be available when the provider is initialised. e.g. when the cli is installed via a provisioner in a terraform cloud instance.
The version of the op cli is now checked before each op command is run.