Allow overrides for disallowed types (e.g. 64 bit integers) #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I swapped my install to this this fork. It is working. |
|
@Lucretiel @inquisitivepenguin Sorry to bother, but could I get a review on this? |
|
This closes #112 for sure. A very beautiful solution I might add! |
|
I'd like to see this included as well. You may also want to add u128 and i128 to the supported types. |
|
@anish-1p sorry to bother you -- would you mind taking a look at this PR and reviewing or merging? Thank you! |
mattyg
added a commit
to rainlanguage/rain.orderbook
that referenced
this pull request
Mar 14, 2024
This was referenced Mar 14, 2024
naveenOnarayanan
added a commit
to gitarcode/typeshare
that referenced
this pull request
Nov 6, 2024
## Description * Switching build over to `zigbuild` to support linux arm64 variant * Porting over 1Password#140 to support large number * Adding some default overrides to include base types for stuff such as `HashSet` ## Test Plan * Typeshare built for repo ## Revert Plan * Revert
naveenOnarayanan
added a commit
to gitarcode/typeshare
that referenced
this pull request
Nov 22, 2024
* Switching build over to `zigbuild` to support linux arm64 variant * Porting over 1Password#140 to support large number * Adding some default overrides to include base types for stuff such as `HashSet` * Typeshare built for repo * Revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an alternative approach to support 64 bit integer types than the one taken in #112.
Rather than blessing one approach, with #119 being merged, it seems like it's possible to accept this oddity of TypeScript/JavaScript and force users of Typeshare (or rather, only those using it to output TypeScript) to make a decision appropriate for them and their use-case.
More or less resolves #24