Skip to content

Commit

Permalink
refactor(side-bar): update alt and title (#327)
Browse files Browse the repository at this point in the history
  • Loading branch information
1chooo committed Sep 29, 2024
1 parent 1a753b2 commit f6eb5e1
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
11 changes: 10 additions & 1 deletion apps/web/src/components/side-bar/avatar-box.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ import { breakpoints } from '@/lib/constants';

import "@/styles/side-bar/avatar-box.css";

import config from '@/config';

const { about } = config;
const {
firstName,
lastName,
middleName,
} = about;

type AvatarBoxProps = {
avatar: string;
};
Expand All @@ -17,7 +26,7 @@ const AvatarBox: React.FC<AvatarBoxProps> = ({ avatar }) => {
<Image
id="profile-img"
src={avatar}
alt="Hugo ChunHo Lin"
alt={`${firstName} (${middleName}) ${lastName}`}
width={imageSize.width}
height={imageSize.height}
loading="lazy"
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/side-bar/info-content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const InfoContent: React.FC = () => (
<div className="info-content">
<h1
className="name"
title="Chun-Ho (Hugo) Lin"
title={`${firstName} (${middleName}) ${lastName}`}
>{firstName} ({middleName}) {lastName}
</h1>
<p className="title">
Expand Down

0 comments on commit f6eb5e1

Please sign in to comment.