Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add universal gasless operation implementation BySig #103

Merged
merged 33 commits into from
Mar 19, 2024
Merged

Add universal gasless operation implementation BySig #103

merged 33 commits into from
Mar 19, 2024

Conversation

k06a
Copy link
Member

@k06a k06a commented Dec 5, 2023

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.21429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.36%. Comparing base (92bb41d) to head (49cf78e).

❗ Current head 49cf78e differs from pull request most recent head 33bcacc. Consider uploading reports for the commit 33bcacc to get more accurate results

Files Patch % Lines
contracts/mixins/BySig.sol 97.77% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   97.19%   97.36%   +0.16%     
==========================================
  Files          14       16       +2     
  Lines         285      341      +56     
  Branches       61       71      +10     
==========================================
+ Hits          277      332      +55     
- Misses          8        9       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k06a k06a changed the title Add BySig abstract contract for universal EIP712 operations for every external function Add universal EIP-712 implementation BySig Dec 5, 2023
@k06a k06a changed the title Add universal EIP-712 implementation BySig Add universal EIP-712 operation implementation BySig Dec 5, 2023
@k06a k06a changed the title Add universal EIP-712 operation implementation BySig Add universal gasless operation implementation BySig Dec 5, 2023
@k06a k06a marked this pull request as ready for review February 2, 2024 12:04
@k06a k06a force-pushed the feature/bysig branch 8 times, most recently from 9cf3403 to 70f0de9 Compare March 18, 2024 15:16
zZoMROT
zZoMROT previously approved these changes Mar 18, 2024
View reviewed changes
ZumZoom
ZumZoom previously approved these changes Mar 19, 2024
View reviewed changes
@ZumZoom ZumZoom merged commit 6d1d795 into master Mar 19, 2024
6 checks passed
@ZumZoom ZumZoom deleted the feature/bysig branch March 19, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZumZoom ZumZoom ZumZoom approved these changes

@zZoMROT zZoMROT zZoMROT left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k06a @ZumZoom @zZoMROT