Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-1140] Export bySig js helpers to package #145

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

zZoMROT
Copy link
Contributor

@zZoMROT zZoMROT commented Jun 4, 2024

Static Code Analysis (readability, compactness):

Hasn't changed

Dynamic Code Analysis (external APIs, interaction flows):

Methods have become available for convenient data preparation for the bySig contract

Efficiency (gas costs, computational complexity, memory requirements):

Hasn't changed

Opinion, trade-offs and other thoughts (optional):

Seems useful, should add

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (176d078) to head (f0c2566).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          17       17           
  Lines         345      345           
  Branches       67       67           
=======================================
  Hits          322      322           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZumZoom ZumZoom merged commit 971276f into master Jun 6, 2024
8 checks passed
@ZumZoom ZumZoom deleted the feature/bysig-js-helpers branch June 6, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants