noop self

1set · Feb 23, 2024 · 566dfc2 · 566dfc2
1 parent d12115d
commit 566dfc2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/dataconv/share.go b/dataconv/share.go
@@ -93,16 +93,6 @@ func (s *SharedDict) Get(k starlark.Value) (v starlark.Value, found bool, err er
 	return nil, false, nil
 }
 
-func (s *SharedDict) Len() int {
-	s.RLock()
-	defer s.RUnlock()
-
-	if s.dict != nil {
-		return s.dict.Len()
-	}
-	return 0
-}
-
 func (s *SharedDict) SetKey(k, v starlark.Value) error {
 	s.Lock()
 	defer s.Unlock()

diff --git a/dataconv/share_test.go b/dataconv/share_test.go
@@ -188,8 +188,10 @@ func TestSharedDict_Functions(t *testing.T) {
 				load('share', 'sd')
 				sd["foo"] = "bar"
 				assert.eq(sd.get("foo"), "bar")
+				assert.eq(sd.len(), 1)
 				sd.clear()
 				assert.eq(sd.get("foo"), None)
+				assert.eq(sd.len(), 0)
 			`),
 		},
 		{