Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] use new NullableDict for lib/http #100

Merged
merged 11 commits into from
May 11, 2024
Merged

[refactor] use new NullableDict for lib/http #100

merged 11 commits into from
May 11, 2024

Conversation

hyorigo
Copy link
Collaborator

@hyorigo hyorigo commented May 11, 2024

No description provided.

Copy link

codacy-production bot commented May 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d9054a5) 4572 4236 92.65%
Head commit (f198f9b) 4557 (-15) 4221 (-15) 92.63% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#100) 81 81 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.10%. Comparing base (d9054a5) to head (f198f9b).

Files Patch % Lines
lib/http/http.go 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   90.13%   90.10%   -0.04%     
==========================================
  Files          39       38       -1     
  Lines        4440     4425      -15     
==========================================
- Hits         4002     3987      -15     
  Misses        330      330              
  Partials      108      108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyorigo hyorigo merged commit 59b0f6f into master May 11, 2024
25 checks passed
@hyorigo hyorigo deleted the usenum branch May 11, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant