Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add uuid and base32 for random lib #48

Merged
merged 6 commits into from
Feb 22, 2024
Merged

[feat] add uuid and base32 for random lib #48

merged 6 commits into from
Feb 22, 2024

Conversation

hyorigo
Copy link
Collaborator

@hyorigo hyorigo commented Feb 22, 2024

No description provided.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5963327) 83.60% compared to head (d7d6235) 83.72%.

Files Patch % Lines
lib/random/random.go 91.42% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   83.60%   83.72%   +0.11%     
==========================================
  Files          22       22              
  Lines        2287     2322      +35     
==========================================
+ Hits         1912     1944      +32     
- Misses        294      296       +2     
- Partials       81       82       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codacy-production bot commented Feb 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.11% (target: -1.00%) 94.44%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5963327) 2355 2054 87.22%
Head commit (d7d6235) 2391 (+36) 2088 (+34) 87.33% (+0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#48) 36 34 94.44%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@hyorigo hyorigo merged commit 95cff61 into master Feb 22, 2024
18 checks passed
@hyorigo hyorigo deleted the uuid branch February 22, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant