fix(content): thessalia dialogue, bunny_ears, scythe #1203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
untradeable_holiday_items.rs2:
New file, as there doesn't seem to be anywhere else appropriate. Any suggestions welcome. It's in
data\src\scripts\player\scripts
which also containspickup.rs2
,cracker.rs2
, which are semi-related and is personal to the player. Is there a better place for this? I considered renamingcracker.rs2
toholiday_items.rs2
, and merge together to reduce clutter and cover any future items (rubber_chicken
hype??).The intention is, which is tested as working:
scythe
:scythe
, and you don't already have one, pick it up and set%scythe_unlocked = 1
scythe
, and you do already have one, don't allow itbunny_ears
:bunny_ears
, and you don't already them, pick it up and set%bunny_ears_unlocked = 1
bunny_ears
, and you do already have one, don't allow itExample, picking up a
![image](https://private-user-images.githubusercontent.com/168375623/410204556-29f6fed1-397f-4aea-9572-fc51ec3cb16f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDk5OTUsIm5iZiI6MTczOTQ0OTY5NSwicGF0aCI6Ii8xNjgzNzU2MjMvNDEwMjA0NTU2LTI5ZjZmZWQxLTM5N2YtNGFlYS05NTcyLWZjNTFlYzNjYjE2Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMjI4MTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lZDUxOGI3ODRjYTk1NjRkM2FmNDIxZTc3YjhkM2ZiNTJiN2ZhOTQzOTBkYzg1YWM2NWEwNTA3MjgwY2IyYWRmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.DiIbok-pe-eLPyHMccgho55xn78norK9wEJ7sDr0cjc)
scythe
after resetting the varp:Setting these varps means the items are retrievable from Thessalia once you've unlocked them. If they are introduced in any other way, other than picking them up off the ground, these varps need to be set in a different way.
varp.pack / all.varp
I'm not sure how to create a new varp without getting an error. I noticed in a recent PR that existing varps were replaced and used. So for this I replaced varp_7 and varp_8. If this should be done differently please let me know.
Example varp_133 and varp_138 replacement: 7d2c20a#diff-9073420bf978748137737c1955094de93363739ad59d436e43a8165cc6fa34dd
which is why I used varp_7 and varp_8
cheat_reset.rs2
Clear the new
%bunny_ears_unlocked
and%scythe_unlocked varps
telegrab.rs2:
Cannot telegrab Bunny ears or Scythe:
https://classic.runescape.wiki/w/Scythe
https://classic.runescape.wiki/w/Bunny_ears
thessalia.rs2:
Dialogue is different in RSC, but the rest of the dialogue currently matches OSRS so I went with that:
https://oldschool.runescape.wiki/w/Transcript:Thessalia
Facial animations also updated