Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#22] Add Helmet middleware; #28

Merged
merged 1 commit into from
Sep 7, 2017
Merged

[#22] Add Helmet middleware; #28

merged 1 commit into from
Sep 7, 2017

Conversation

kirilknysh
Copy link
Member

@kirilknysh kirilknysh commented Aug 25, 2017

Before:

HTTP/1.1 200 OK
X-Powered-By: Express
Accept-Ranges: bytes
Cache-Control: public, max-age=0
Last-Modified: Tue, 15 Aug 2017 13:55:08 GMT
ETag: W/"11c7-15de62d3260"
Content-Type: text/html; charset=UTF-8
Content-Length: 4551
Date: Fri, 25 Aug 2017 14:52:18 GMT
Connection: keep-alive

After:

HTTP/1.1 200 OK
X-Frame-Options: SAMEORIGIN
Strict-Transport-Security: max-age=15552000; includeSubDomains
X-Download-Options: noopen
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
Accept-Ranges: bytes
Cache-Control: public, max-age=0
Last-Modified: Tue, 15 Aug 2017 13:55:08 GMT
ETag: W/"11c7-15de62d3260"
Content-Type: text/html; charset=UTF-8
Content-Length: 4551
Date: Fri, 25 Aug 2017 15:07:05 GMT
Connection: keep-alive

Closes #22

@DaQuirm
Copy link
Member

DaQuirm commented Aug 25, 2017

Looks like X-Powered-By didn't make it 😞

@DaQuirm
Copy link
Member

DaQuirm commented Aug 25, 2017

LGTM, but has to undergo full gunslinger testing IMHO

@kirilknysh
Copy link
Member Author

Definitely, testing first!

@DaQuirm
Copy link
Member

DaQuirm commented Sep 7, 2017

Tested, works well with red wine 🍷
See #30
img_1144

@DaQuirm DaQuirm merged commit cc4a153 into master Sep 7, 2017
@DaQuirm DaQuirm deleted the feature/helmet branch September 7, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants