[WIP] Add migration support for sqlite, better validation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/migrations
…to-knex into feature/migrations
JeffSpies
reviewed
Apr 25, 2019
| @@ -55,9 +56,15 @@ const types = { | |||
| }, | |||
| uuid: (table, name) => { | |||
| return table.uuid(name); | |||
| }, | |||
| foreign: (table, name, options) => { | |||
| debugger; | |||
| async function createColumn(table, column, alter = false) { | ||
| const columnName = column.name; | ||
| // e.g., id: { type: "increments" } | ||
| debugger; |
| const tableName = tableConfig.name; | ||
| chain = createTable(chain, tableName, tableConfig); | ||
| }); | ||
| chain = await createTable(chain, tableName, tableConfig); |
| * Adds the new schema to the migrations table and applies the relevant database changes to the rest of the db | ||
| * @param {*} schema | ||
| */ | ||
| async addMigration(schema) { |
There was a problem hiding this comment.
Does this logic need to be contained in a transaction?
| * @param {JSON} newSchema | ||
| */ | ||
| function getColumnsToRemove(oldSchema, newSchema) { | ||
| return _.differenceBy(oldSchema.columns, newSchema.columns, "name"); |
There was a problem hiding this comment.
Any reason to use a json diffing library here? I suppose we don't need much functionality here.
| }); | ||
|
|
||
| // get the resulting schema | ||
| // TODO: this might not be necessary, could just use the schema obj passed into the method instead of newSchema |
There was a problem hiding this comment.
If the schema object has been validated (and default values imputed?), then probably not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.