Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSCO-5 adds ui metadata to hide callflows for apps #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MSCO-5 adds ui metadata to hide callflows for apps #82

wants to merge 2 commits into from

Conversation

ashleyvernon
Copy link

No description provided.

@ashleyvernon ashleyvernon changed the title adds ui metadata to hide callflows for apps MSCO-5 adds ui metadata to hide callflows for apps Nov 9, 2019
joristirado
joristirado reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@joristirado joristirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this now rather long list is repeated at two different locations, it would be nice to store it inside an appFlags and use references to it.

This way, updating it in the future will be super duper easy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joristirado joristirado joristirado left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleyvernon @joristirado