Week3 #3
Open
Week3 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdb1217
approved these changes
Nov 4, 2021
hansh0101
reviewed
Nov 11, 2021
| binding.tvIntroduction.text = data.introduction | ||
| Glide.with(itemView.context).load(data.photo) | ||
| .apply(RequestOptions.circleCropTransform()) | ||
| .into(binding.ivProfile) |
There was a problem hiding this comment.
Glide.with()
.load()
.apply()
.into()
로 코드를 작성하면 더 가독성이 좋아질 것 같아요
| binding.vpSample.currentItem = THIRD_FRAGMENT | ||
| return@setOnItemSelectedListener true | ||
| } | ||
| } |
There was a problem hiding this comment.
생각해봤는데 return@setOnItemSelectedListener true는 모든 분기문마다 공통이니까 when문 바깥에서 한 줄만 써도 되지 않을까요?
| binding.btnFollower.isSelected = true; | ||
| binding.btnRepository.isSelected = false; | ||
| } | ||
|
|
There was a problem hiding this comment.
childFragmentManager라는 것도 있는데 한 번 찾아보면 좋을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
week3