Update SettingsManager.kt #4207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xray-core can bypass private IPs and no need to bypass private IPs in vpn-code. in addition routing rules is for xray-core only and should not used for vpn-code. problems such as: cannot block specific private ip. cannot block specific port of private ips. and .... will occur if you use it in vpn-code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xray-core can bypass private IPs and no need to bypass private IPs in vpn-code.
and just because geoip/geosite:private rule exist (and route to direct) is not a valid reason to bypass lan in vpn-code and all other rules must be considered .
in addition routing rules is for xray-core only and should not used for vpn-code.
problems such as:
cannot block specific private ip.
cannot block specific port of private ips.
and ....
will occur if bypass all lan ips in vpn code.
and in the last if the bypass lan in vpn code is necessary(why?) you can put simple checkbox for it.