Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TILES-6869 fix depth msaa #38

Merged
merged 2 commits into from
Oct 11, 2024
Merged

TILES-6869 fix depth msaa #38

merged 2 commits into from
Oct 11, 2024

Conversation

Kuznecoff
Copy link
Collaborator

@Kuznecoff Kuznecoff commented Oct 9, 2024 •
edited
Loading

  • Fixed msaa texture drawing on canvas, depth mask from texture to canvas is now disabled.
  • Skip use stateBinder function for fix heatmap layer - this fix was not will be useful.

@EvgenyRodygin
Copy link
Contributor

В описании сказано: " turn off depth test and skip write depth to canvas",
но я не вижу "turn off depth test" в MR. Только отключение записи в глубину. Это нормально?

И я не понял, как исправлен рендеринг в мультисэмпловую текстуру. Вот как раз изменениями стейтов глубины?

EvgenyRodygin
EvgenyRodygin reviewed Oct 10, 2024
View reviewed changes
src/deckgl2gisLayer.ts Outdated
gl.drawArrays(gl.TRIANGLES, 0, 6);
gl.depthMask(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему маска устанавливается именно в true?
Не корректнее ли её устанавливать в то значение, которое было до вызова gl.drawArrays?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точно - поправил.

@EvgenyRodygin EvgenyRodygin self-requested a review October 11, 2024 07:16
@EvgenyRodygin
Copy link
Contributor

Больше замечаний нет. Аппрув

@Kuznecoff Kuznecoff merged commit 36e5142 into master Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvgenyRodygin EvgenyRodygin EvgenyRodygin approved these changes

@alxart alxart alxart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kuznecoff @EvgenyRodygin @alxart