Skip to content

Commit

Permalink
Build custom hub image with jh41 compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio committed Apr 2, 2024
1 parent 004a100 commit 5c951e8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 16 deletions.
12 changes: 6 additions & 6 deletions helm-charts/images/hub/dynamic-image-building-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# Image lives at quay.io/2i2c/dynamic-image-building-experiment

# jupyterhub-configurator isn't version controlled, so we pin to a specific
# commit currently. Available commits are found at
# https://github.com/yuvipanda/jupyterhub-configurator/commits/main
# jupyterhub-configurator isn't maintained and its not intended to be developed
# further. We are using a branch that has forked from the main branch just
# before a breaking change were made. This allows us to avoid migrating.
#
# FIXME: ed7e3a0df1e3d625d10903ef7d7fd9c2fbb548db is from Mar 26, 2021, but
# several commits has been made since.
# ref: https://github.com/yuvipanda/jupyterhub-configurator/commits/main
# ref: https://github.com/yuvipanda/jupyterhub-configurator/commits/backported-jh41-compatibility
#
git+https://github.com/yuvipanda/jupyterhub-configurator@ed7e3a0df1e3d625d10903ef7d7fd9c2fbb548db
git+https://github.com/yuvipanda/jupyterhub-configurator@backported-jh41-compatibility

# Brings in https://github.com/yuvipanda/jupyterhub-fancy-profiles
jupyterhub-fancy-profiles==0.2.0
16 changes: 6 additions & 10 deletions helm-charts/images/hub/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
# Image lives at quay.io/2i2c/pilot-hub

# jupyterhub-configurator isn't version controlled, so we pin to a specific
# commit currently. Available commits are found at
# https://github.com/yuvipanda/jupyterhub-configurator/commits/main
# jupyterhub-configurator isn't maintained and its not intended to be developed
# further. We are using a branch that has forked from the main branch just
# before a breaking change were made. This allows us to avoid migrating.
#
# FIXME: bc7aaab136c8eff3619d18151f35437c64d6f7d1 is from Mar 30, 2021, but
# several commits has been made since as can be seen via
# https://github.com/yuvipanda/jupyterhub-configurator/compare/bc7aaab136c8eff3619d18151f35437c64d6f7d1...main,
# where the commit after the one we currently use removes
# c.Configurator.schemas that we configure in our provided
# jupyterhub_configurator_config.py.
# ref: https://github.com/yuvipanda/jupyterhub-configurator/commits/main
# ref: https://github.com/yuvipanda/jupyterhub-configurator/commits/backported-jh41-compatibility
#
git+https://github.com/yuvipanda/jupyterhub-configurator@bc7aaab136c8eff3619d18151f35437c64d6f7d1
git+https://github.com/yuvipanda/jupyterhub-configurator@backported-jh41-compatibility

0 comments on commit 5c951e8

Please sign in to comment.