Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up image building UI to binderhub service in imagebuilding-demo #3145

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Wire up image building UI to binderhub service in imagebuilding-demo #3145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16ab667
Make binderhub-service available externally via CHP
yuvipanda Sep 15, 2023
f02ed7a
Bump dynamic image UI to latest version
yuvipanda Sep 15, 2023
27f23c1
Build and bump hub image
yuvipanda Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion config/clusters/2i2c/imagebuilding-demo.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,14 @@ jupyterhub:
mem_limit: 2G
cpu_limit: 2
hub:
services:
binder:
# FIXME: ref https://github.com/2i2c-org/binderhub-service/issues/57
# for something more readable and requiring less copy-pasting
url: http://imagebuilding-demo-binderhub-service:8090
image:
name: quay.io/2i2c/dynamic-image-building-experiment
tag: "0.0.1-0.dev.git.6765.h33942a27"
tag: "0.0.1-0.dev.git.7001.hf02ed7a1"
config:
JupyterHub:
authenticator_class: cilogon
Expand Down Expand Up @@ -107,6 +112,7 @@ binderhub-service:
effect: NoSchedule
config:
BinderHub:
base_url: /services/binder
use_registry: true
# Re-uses the registry created for the `binderhub-staging` hub
# but pushes images under a different prefix
Expand Down
2 changes: 1 addition & 1 deletion helm-charts/images/hub/dynamic-image-building-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ git+https://github.com/yuvipanda/jupyterhub-configurator@ed7e3a0df1e3d625d10903e
# Brings on using `unlisted_choice` in profile options per https://github.com/2i2c-org/infrastructure/issues/2146
git+https://github.com/jupyterhub/kubespawner@5a90351adba7d65286bd5e00e82f156011bf7b83
# Brings in https://github.com/yuvipanda/prototype-kubespawner-dynamic-building-ui
git+https://github.com/yuvipanda/prototype-kubespawner-dynamic-building-ui.git@b36ece00b5e7fcba5d4485e7ab70992705601c3c
git+https://github.com/yuvipanda/prototype-kubespawner-dynamic-building-ui.git@2f9b899cb6d7ea91f0e5f69c48562a1cd73fc3da