Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow restricting profiles & profile_options based on JupyterHub groups #3883

Merged
merged 17 commits into from
May 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup some earthscope config
  • Loading branch information
yuvipanda committed May 7, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit a9ff316d8c1c0a1fc0d2d1435baeb95da7e3289f
7 changes: 3 additions & 4 deletions config/clusters/earthscope/common.values.yaml
Original file line number Diff line number Diff line change
@@ -78,7 +78,9 @@ basehub:

async def authenticate(self, *args, **kwargs):
resp = await super().authenticate(*args, **kwargs)
# Set scope to groups
# Setup groups to be same as list of scopes granted
# This can go away after https://github.com/jupyterhub/oauthenticator/pull/735 is
# merged
resp["groups"] = resp["auth_state"]["scope"]
return resp

@@ -99,8 +101,6 @@ basehub:

c.JupyterHub.authenticator_class = CustomGenericOAuthenticator
config:
# JupyterHub:
# authenticator_class: auth0
CustomGenericOAuthenticator:
required_scopes:
# This allows EarthScope to control who can login to the hub
@@ -123,7 +123,6 @@ basehub:
username_claim: sub
# Convert 'scope' from the OAuth2 response into JupyterHub groups
manage_groups: true
# claim_groups_key: 'scope'
CILogonOAuthenticator:
allowed_idps:
http://github.com/login/oauth/authorize: