Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker tweaks #115

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Docker tweaks #115

merged 2 commits into from
Feb 26, 2024

Conversation

mattbell87
Copy link
Member

Description

Changelog

  • Configurable core branch
  • Improved container logs, and setup script
  • Better docker documentation
  • Other minor tweaks

@mattbell87 mattbell87 changed the base branch from master to develop February 26, 2024 03:55
@mattbell87
Copy link
Member Author

@adam-buckley this will be useful for CI. If the environment variable CMFIVE_CORE_BRANCH is set it will tell cmfive to install the core on that branch:
image

@mattbell87 mattbell87 merged commit dc17fad into develop Feb 26, 2024
9 checks passed
@mattbell87 mattbell87 deleted the feat/cmfive-docker-tweaks branch February 26, 2024 06:45
@mattbell87 mattbell87 mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-bateman chris-bateman chris-bateman approved these changes

@adam-buckley adam-buckley Awaiting requested review from adam-buckley

Assignees

@mattbell87 mattbell87

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattbell87 @chris-bateman