Feature/name email search list users #184
Conversation
system/templates/base/.gitignore
Outdated
| dist/ | ||
| package-lock.json |
There was a problem hiding this comment.
Remove this and add package-lock.json back in
There was a problem hiding this comment.
Sorry I didn't see this earlier. when I remove the dist/ folder from .gitignore I get 8 files form the dist folder and below that want to be committed - Do we want to commit these files as well?
There was a problem hiding this comment.
Dist should still be left out, we just need to not add packaage-lock.json to .gitignore
…five-core into feature/FormBannerSupport Merging config setup by Adam
…five-core into feature/FormBannerSupport
Incorporating codeception updates
| @@ -48,3 +56,20 @@ function index_ALL(Web $w) | |||
| //send the table to the template using ctx | |||
| $w->ctx('insightTable', Html::table($table, 'insight_table', 'tablesorter', $tableHeaders)); | |||
| } | |||
|
|
|||
| // Function to recursively check if a user is a member of a group (or parent group) | |||
| function checkUserAccess(Web $w, $group, $user_id) : bool { | |||
There was a problem hiding this comment.
Avoid putting extra functions in action files. They should instead be in the Service class
There was a problem hiding this comment.
After putting the function into InsightService
eg public function checkUserAccess(Web $w, $group, $user_id): bool
How does the action function find the function in the service class?
I get "undefined function" if called as "checkUserAccess(...)"
and "Non static method 'checkUserAccess' should not be called statically." if I called as "InsightService::checkUserAccess(...)"
There was a problem hiding this comment.
btw should "checkUserAccess(...)" function go in InsightService or AuthService?
system/templates/base/.gitignore
Outdated
| dist/ | ||
| package-lock.json |
There was a problem hiding this comment.
Dist should still be left out, we just need to not add packaage-lock.json to .gitignore
adam-buckley
requested review from
dragonflyfree and
adam-buckley
and removed request for
careck
|
Moved to draft cause I dont think this PR offers anything anymore. Holding off to make sure soon |
Checklist
Description
Added Login, Name and Email filter to List Users function within Admin menu.
Filter fields match any part of the target string.
"Name" searches first and last names for a match.
Changelog
refs:
issues:
Other Information
Docs pull request: